diff --git a/resources/views/admin/site_subscriptions/show.blade.php b/resources/views/admin/site_subscriptions/show.blade.php index 8e6b616..e546e47 100644 --- a/resources/views/admin/site_subscriptions/show.blade.php +++ b/resources/views/admin/site_subscriptions/show.blade.php @@ -333,13 +333,32 @@

BMPA 失败原因Top3

- @php $bmpaFailedReasonStats = $bmpaFailedReasonStats ?? []; @endphp + @php + $bmpaFailedReasonStats = $bmpaFailedReasonStats ?? []; + // 避免 URL 过长/特殊字符破坏 query:原因过长则不生成 keyword 链接 + $FAILED_REASON_KEYWORD_MAX_LEN = 80; + @endphp @if(count($bmpaFailedReasonStats) > 0)
@foreach($bmpaFailedReasonStats as $item) - @php $reason = (string) ($item['reason'] ?? ''); @endphp + @php + $reason = (string) ($item['reason'] ?? ''); + $reasonUrl = ''; + if ($reason !== '' && mb_strlen($reason) <= $FAILED_REASON_KEYWORD_MAX_LEN) { + $reasonUrl = $makePlatformOrderUrl([ + 'site_subscription_id' => $subscription->id, + 'bmpa_failed_only' => '1', + 'bmpa_error_keyword' => $reason, + ]); + } + @endphp
- {{ $reason }} + @if($reasonUrl) + {{ $reason }} + @else + {{ $reason }} + (原因过长,请复制到筛选框) + @endif ({{ $item['count'] }})
@endforeach @@ -355,9 +374,24 @@ @if(count($failedReasonStats) > 0)
@foreach($failedReasonStats as $item) - @php $reason = (string) ($item['reason'] ?? ''); @endphp + @php + $reason = (string) ($item['reason'] ?? ''); + $reasonUrl = ''; + if ($reason !== '' && mb_strlen($reason) <= $FAILED_REASON_KEYWORD_MAX_LEN) { + $reasonUrl = $makePlatformOrderUrl([ + 'site_subscription_id' => $subscription->id, + 'sync_status' => 'failed', + 'sync_error_keyword' => $reason, + ]); + } + @endphp
- {{ $reason }} + @if($reasonUrl) + {{ $reason }} + @else + {{ $reason }} + (原因过长,请复制到筛选框) + @endif ({{ $item['count'] }})
@endforeach diff --git a/tests/Feature/AdminSiteSubscriptionBmpaFailedReasonLongDoesNotRenderKeywordLinkTest.php b/tests/Feature/AdminSiteSubscriptionBmpaFailedReasonLongDoesNotRenderKeywordLinkTest.php new file mode 100644 index 0000000..7444acd --- /dev/null +++ b/tests/Feature/AdminSiteSubscriptionBmpaFailedReasonLongDoesNotRenderKeywordLinkTest.php @@ -0,0 +1,91 @@ +seed(); + + $this->post('/admin/login', [ + 'email' => 'platform.admin@demo.local', + 'password' => 'Platform@123456', + ])->assertRedirect('/admin'); + } + + public function test_subscription_show_page_does_not_render_bmpa_keyword_link_when_reason_too_long(): void + { + $this->loginAsPlatformAdmin(); + + $merchant = Merchant::query()->firstOrFail(); + $plan = Plan::query()->create([ + 'code' => 'sub_bmpa_long_reason_01', + 'name' => '订阅BMPA失败原因过长护栏测试套餐', + 'billing_cycle' => 'monthly', + 'price' => 10, + 'list_price' => 10, + 'status' => 'active', + 'sort' => 10, + 'published_at' => now(), + ]); + + $sub = SiteSubscription::query()->create([ + 'merchant_id' => $merchant->id, + 'plan_id' => $plan->id, + 'status' => 'activated', + 'source' => 'manual', + 'subscription_no' => 'SUB_BMPA_LONG_REASON_0001', + 'plan_name' => $plan->name, + 'billing_cycle' => $plan->billing_cycle, + 'period_months' => 1, + 'amount' => 10, + 'starts_at' => now()->subDay(), + 'ends_at' => now()->addMonth(), + 'activated_at' => now()->subDay(), + ]); + + $longReason = str_repeat('中', 120); + + PlatformOrder::query()->create([ + 'merchant_id' => $merchant->id, + 'plan_id' => $plan->id, + 'site_subscription_id' => $sub->id, + 'created_by_admin_id' => 1, + 'order_no' => 'PO_SUB_BMPA_LONG_REASON_0001', + 'order_type' => 'renewal', + 'status' => 'pending', + 'payment_status' => 'unpaid', + 'plan_name' => $plan->name, + 'billing_cycle' => $plan->billing_cycle, + 'period_months' => 1, + 'quantity' => 1, + 'payable_amount' => 10, + 'paid_amount' => 0, + 'placed_at' => now(), + 'meta' => [ + 'batch_mark_paid_and_activate_error' => [ + 'message' => $longReason, + 'at' => now()->toDateTimeString(), + 'admin_id' => 1, + ], + ], + ]); + + $res = $this->get('/admin/site-subscriptions/' . $sub->id); + $res->assertOk(); + + $res->assertSee('BMPA 失败原因Top3'); + $res->assertDontSee('bmpa_error_keyword=', false); + $res->assertSee('原因过长,请复制到筛选框', false); + } +} diff --git a/tests/Feature/AdminSiteSubscriptionBmpaFailedReasonStatsLinksTest.php b/tests/Feature/AdminSiteSubscriptionBmpaFailedReasonStatsLinksTest.php index 8dd860c..a7a584f 100644 --- a/tests/Feature/AdminSiteSubscriptionBmpaFailedReasonStatsLinksTest.php +++ b/tests/Feature/AdminSiteSubscriptionBmpaFailedReasonStatsLinksTest.php @@ -105,6 +105,7 @@ class AdminSiteSubscriptionBmpaFailedReasonStatsLinksTest extends TestCase ]); $this->get('/admin/site-subscriptions/' . $sub->id) + ->assertOk() ->assertOk() ->assertSee('BMPA 失败原因Top3') ->assertSee('回执总额与应付金额不一致') diff --git a/tests/Feature/AdminSiteSubscriptionSyncFailedReasonLongDoesNotRenderKeywordLinkTest.php b/tests/Feature/AdminSiteSubscriptionSyncFailedReasonLongDoesNotRenderKeywordLinkTest.php new file mode 100644 index 0000000..80c8e6b --- /dev/null +++ b/tests/Feature/AdminSiteSubscriptionSyncFailedReasonLongDoesNotRenderKeywordLinkTest.php @@ -0,0 +1,93 @@ +seed(); + + $this->post('/admin/login', [ + 'email' => 'platform.admin@demo.local', + 'password' => 'Platform@123456', + ])->assertRedirect('/admin'); + } + + public function test_subscription_show_page_does_not_render_sync_keyword_link_when_reason_too_long(): void + { + $this->loginAsPlatformAdmin(); + + $merchant = Merchant::query()->firstOrFail(); + $plan = Plan::query()->create([ + 'code' => 'sub_sync_long_reason_01', + 'name' => '订阅同步失败原因过长护栏测试套餐', + 'billing_cycle' => 'monthly', + 'price' => 10, + 'list_price' => 10, + 'status' => 'active', + 'sort' => 10, + 'published_at' => now(), + ]); + + $sub = SiteSubscription::query()->create([ + 'merchant_id' => $merchant->id, + 'plan_id' => $plan->id, + 'status' => 'activated', + 'source' => 'manual', + 'subscription_no' => 'SUB_SYNC_LONG_REASON_0001', + 'plan_name' => $plan->name, + 'billing_cycle' => $plan->billing_cycle, + 'period_months' => 1, + 'amount' => 10, + 'starts_at' => now()->subDay(), + 'ends_at' => now()->addMonth(), + 'activated_at' => now()->subDay(), + ]); + + $longReason = str_repeat('错', 120); + + PlatformOrder::query()->create([ + 'merchant_id' => $merchant->id, + 'plan_id' => $plan->id, + 'site_subscription_id' => $sub->id, + 'created_by_admin_id' => 1, + 'order_no' => 'PO_SUB_SYNC_LONG_REASON_0001', + 'order_type' => 'renewal', + 'status' => 'activated', + 'payment_status' => 'paid', + 'plan_name' => $plan->name, + 'billing_cycle' => $plan->billing_cycle, + 'period_months' => 1, + 'quantity' => 1, + 'payable_amount' => 10, + 'paid_amount' => 10, + 'placed_at' => now(), + 'paid_at' => now(), + 'activated_at' => now(), + 'meta' => [ + 'subscription_activation_error' => [ + 'message' => $longReason, + 'at' => now()->toDateTimeString(), + 'admin_id' => 1, + ], + ], + ]); + + $res = $this->get('/admin/site-subscriptions/' . $sub->id); + $res->assertOk(); + + $res->assertSee('同步失败原因Top3'); + $res->assertDontSee('sync_error_keyword=', false); + $res->assertSee('原因过长,请复制到筛选框', false); + } +}