From 0cef9b6186fb33c7b38542d605dac96a82e9e3bc Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E8=90=9D=E5=8D=9C?= <dev@saasshop.local>
Date: Mon, 16 Mar 2026 16:52:42 +0800
Subject: [PATCH] fix(admin-js): merchant revenue rank bars use ratio (no
 undefined barRatio)

---
 public/js/admin.js                            |  2 +-
 ...ChartShouldNotUseUndefinedBarRatioTest.php | 24 +++++++++++++++++++
 2 files changed, 25 insertions(+), 1 deletion(-)
 create mode 100644 tests/Feature/AdminJsMerchantRevenueRank7dChartShouldNotUseUndefinedBarRatioTest.php

diff --git a/public/js/admin.js b/public/js/admin.js
index 3225f47..de376e7 100644
--- a/public/js/admin.js
+++ b/public/js/admin.js
@@ -229,7 +229,7 @@
 
             var bar = document.createElement('div');
             bar.className = 'adm-mini-rank-bar';
-            bar.style.width = Math.round(barRatio * 100) + '%';
+            bar.style.width = Math.round(ratio * 100) + '%';
 
             wrap.appendChild(bar);
 
diff --git a/tests/Feature/AdminJsMerchantRevenueRank7dChartShouldNotUseUndefinedBarRatioTest.php b/tests/Feature/AdminJsMerchantRevenueRank7dChartShouldNotUseUndefinedBarRatioTest.php
new file mode 100644
index 0000000..7c54948
--- /dev/null
+++ b/tests/Feature/AdminJsMerchantRevenueRank7dChartShouldNotUseUndefinedBarRatioTest.php
@@ -0,0 +1,24 @@
+<?php
+
+namespace Tests\Feature;
+
+use Tests\TestCase;
+
+class AdminJsMerchantRevenueRank7dChartShouldNotUseUndefinedBarRatioTest extends TestCase
+{
+    public function test_admin_js_merchant_revenue_rank_7d_chart_should_not_use_undefined_bar_ratio(): void
+    {
+        $js = (string) file_get_contents(public_path('js/admin.js'));
+
+        // 保护：Top5 站点收入排行条形图应使用 ratio 变量（paid/max），不应引用 barRatio。
+        $this->assertStringContainsString(
+            "bar.className = 'adm-mini-rank-bar';\n            bar.style.width = Math.round(ratio * 100)",
+            $js
+        );
+
+        $this->assertStringNotContainsString(
+            "bar.className = 'adm-mini-rank-bar';\n            bar.style.width = Math.round(barRatio * 100)",
+            $js
+        );
+    }
+}