套餐页 back 安全护栏:快捷筛选仅透传安全 back(补测试)

This commit is contained in:
萝卜
2026-03-14 15:42:32 +00:00
parent a6179718ad
commit 08488257ca
2 changed files with 68 additions and 12 deletions

View File

@@ -54,16 +54,28 @@
@php
// 快捷筛选仅保留“上下文”字段back/keyword避免把其它筛选条件叠加导致空结果
$buildQuickFilterUrl = function (array $overrides) {
// 统一的 back 安全护栏:本页大量 href 采用 `{!! !!}` 原样输出,必须严控 back 注入与 nested back。
$incomingBack = (string) request()->query('back', '');
$safeBackForLinks = (str_starts_with($incomingBack, '/')
&& !preg_match('/["\'<>]/', $incomingBack)
// back 本身不应再包含 back避免无限嵌套导致 URL 膨胀)
&& !preg_match('/(?:^|[?&])back=/', $incomingBack))
? $incomingBack
: '';
$buildQuickFilterUrl = function (array $overrides) use ($safeBackForLinks) {
$path = '/' . ltrim(request()->path(), '/');
$contextKeys = [
'back' => 1,
'keyword' => 1,
];
$q = array_intersect_key(request()->query(), $contextKeys);
if ($safeBackForLinks !== '') {
$q['back'] = $safeBackForLinks;
}
foreach ($overrides as $k => $v) {
if ($v === null) {
unset($q[$k]);
@@ -79,17 +91,14 @@
return $path . '?' . \Illuminate\Support\Arr::query($q);
};
// “全部”:清空筛选,但保留 back用于返回来源页
$incomingBack = (string) request()->query('back', '');
$safeBack2 = (str_starts_with($incomingBack, '/')
&& !preg_match('/["\'<>]/', $incomingBack)
// back 本身不应再包含 back避免无限嵌套导致 URL 膨胀)
&& !preg_match('/(?:^|[?&])back=/', $incomingBack))
? $incomingBack
: '';
// “全部”:清空筛选,但保留安全 back用于返回来源页
$allUrl = '/admin/plans';
if ($safeBack2 !== '') {
$allUrl .= '?' . \Illuminate\Support\Arr::query(['back' => $safeBack2]);
if ($safeBackForLinks !== '') {
$allUrl .= '?' . \Illuminate\Support\Arr::query(['back' => $safeBackForLinks]);
}
if ($safeBackForLinks !== '') {
$allUrl .= '?' . \Illuminate\Support\Arr::query(['back' => $safeBackForLinks]);
}
@endphp

View File

@@ -0,0 +1,47 @@
<?php
namespace Tests\Feature;
use Illuminate\Foundation\Testing\RefreshDatabase;
use PHPUnit\Framework\Attributes\DataProvider;
use Tests\TestCase;
class AdminPlanIndexUnsafeBackShouldBeDroppedForLinksTest extends TestCase
{
use RefreshDatabase;
protected function loginAsPlatformAdmin(): void
{
$this->seed();
$this->post('/admin/login', [
'email' => 'platform.admin@demo.local',
'password' => 'Platform@123456',
])->assertRedirect('/admin');
}
public static function invalidBackProvider(): array
{
return [
'contains quote' => ['/' . 'admin/plans?x="y"'],
'contains angle bracket' => ['/admin/plans?x=<script>'],
'nested back param' => ['/admin/plans?status=active&back=/admin/platform-orders'],
'absolute url' => ['https://evil.example.com'],
];
}
#[DataProvider('invalidBackProvider')]
public function test_index_should_drop_unsafe_back_for_links(string $back): void
{
$this->loginAsPlatformAdmin();
$res = $this->get('/admin/plans?back=' . urlencode($back));
$res->assertOk();
// 不应渲染 back 回退入口
$res->assertDontSee('返回上一页(保留上下文)');
// 快捷筛选链接不应透传 unsafe back
$res->assertDontSee('back=' . $back, false);
}
}